-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add climate preset tile feature #17946
Add climate preset tile feature #17946
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hello 👋 Thank you for the contribution. |
Yup, I realised when messing with it. Maybe we could either exclude custom presets, or allow the user to configure an icon for each custom preset? Only issue with the latter would be how to handle additional presets which turn up after the card has already been configured. We could include them (with no icon, which just doesn't fix anything), or just ignore them and the card must manually be reconfigured for them to show up. Either way, not an ideal solution. Maybe use the custom preset's first letter as opposed to the entire name? But again, won't work very well if there are multiple custom presets which start with the same letter. Idk, if you can come up with a better solution, please let me know. |
I discussed with the design team and we can not use icon only component for custom presets because some custom presets doesn't have icon. We will also look how we can provide icons for custom presets (not only in tile card but for more info too) and then having icon only component for preset mode can make sense. |
No worries, makes sense. As a compromise, how about only including presets with known icons (ie. all the default ones) for now, until a better solution is found?
That would be quite interesting. I feel like the tile cards work so well because of their simplicity, and the other option, a drop down, might undo some of that. I guess it's always better to have something than nothing though, and if the dropdown feature could be reused for other stuff, that's even better. |
src/panels/lovelace/create-element/create-tile-feature-element.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts
Outdated
Show resolved
Hide resolved
Hello 👋 |
Proposed change
Adds climate preset mode feature to tile card.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: