Simplify data table template #17825
Merged
Simplify data table template #17825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
simplify_data_table_template
branch
3 times, most recently
from
de2b0ad to
760e509
Compare
github-actions
bot
added
Supervisor
piitaya
force-pushed
the
simplify_data_table_template
branch
from
31aed6e to
b9ab4c9
Compare
bramkragten
approved these changes
Sep 20, 2023
LaUr3nTiU
reviewed
Oct 9, 2023
| @@ -68,7 +68,7 @@ export class HaConfigUsers extends LitElement { | |||
| width: "20%", | |||
| direction: "asc", | |||
| hidden: narrow, | |||
| template: (username) => html`${username || "—"}`, | |||
| template: (user) => html`${user.name || "—"}`, | |||
There was a problem hiding this comment.
This should be user.username, as now the Users table lists the Name twice, and the Username never.
There was a problem hiding this comment.
Adding @piitaya - not sure if you'll get notified otherwise.
There was a problem hiding this comment.
I'm not sure if this is being tracked anywhere. Do you want me to raise an issue?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Only the full object instead of the property and the full object.
The value can be easily retrieve with
entry[property]. This would simplify the data table usage and make the typing easier.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: