Add label to location selector

[joostlek]

Proposed change

Before this change, the label of a location selector wasn't used even tho an integration might have given a label to support the type of data going in.
Before:

After:

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[frenck]

I think it was omitted on purpose, as this is kinda assumed at this point?

@matthiasdebaat WDYT?

[matthiasdebaat]

I agree. Why do you want to add this @joostlek?

[joostlek]

I found it strange that we do define this label in core, but it isn't shown. For example at Tankerkoenig, you just get a map without any context

(of course this would be solved with a description or something).

And maybe for integrations that require 2 locations (google travel time might be an example) it would be useful to add some context.

But personally I just noticed that this wasn't consistent so I am also fine if we just keep it as is.

[bramkragten]

I think it makes sense to add this, the user of the form should make the decision if the label is needed or not, for example if there are multiple locations to be picked

[matthiasdebaat]

Fair point. It's strange that the name doesn't show up when you set one. Though in the example of Tankerkoenig, the name is required and not a decision of the user.

[matthiasdebaat]

Let's give it a bit more spacing between the name and map and use the same header as we use for History and Logbook.

[joostlek]

[spacegaier]

I am going to close and re-open since that should restart the stuck CI checks

[spacegaier]

Styling wise I am wondering if we shouldn't follow the style of "Fuel types" since the map is basically just a form input and not a separate section like logbook or history? Space between label and map looks good to me.

[joostlek]

I was thinking the same, but I am definitely not an UIUX expert

[matthiasdebaat]

Styling wise I am wondering if we shouldn't follow the style of "Fuel types" since the map is basically just a form input

I agree. Had a bad assumption that it was the same font as logbook.