Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label support #16626

Closed
wants to merge 5 commits into from
Closed

Add label support #16626

wants to merge 5 commits into from

Conversation

frenck
Copy link
Member

@frenck frenck commented May 25, 2023

Proposed change

Add support for labels.

For more context/info see: home-assistant/core#69996

Needs: home-assistant/home-assistant-js-websocket#383

CleanShot 2023-11-04 at 17 47 29@2x

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale label Oct 12, 2023
@johntdyer

This comment was marked as off-topic.

@github-actions github-actions bot removed the stale label Oct 12, 2023
@frenck frenck mentioned this pull request Nov 4, 2023
22 tasks
@github-actions github-actions bot added Demo Related to frontend demo content Design Related to Home Assistant design gallery labels Nov 4, 2023
[labelId: string]: DeviceRegistryEntry[];
}

export interface LabelRegistryEntryMutableParams {
Copy link
Member

@bramkragten bramkragten Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface LabelRegistryEntryMutableParams {
export type LabelRegistryEntryMutableParams = Omit<"label_id", LabelRegistryEntry>

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 26, 2024
@github-actions github-actions bot closed this Mar 4, 2024
@bendikrb
Copy link

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Demo Related to frontend demo content Design Related to Home Assistant design gallery stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants