-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyialarm to 2.2.0 #74874
Update pyialarm to 2.2.0 #74874
Conversation
If possible it would be good to include this in the next release 2022.7.3, because unfortunately the upgrade to Python 3.10 is currently preventing this integration to work. |
I dont really like the monkeypatching of collections. It affects all other modules in home assistant. I dont have any other easy solution though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency bump contains code we cannot accept in our project:
See:
The dependency now will overwrite Python internals, which will affect everything else in this project.
Hmm, let me check if there is a valid alternative to dicttoxml. |
a723240
to
e5c7902
Compare
I replaced (pyialarm 2.1.5 also tries to reuse the same connections multiple times and adds a small delay between the requests as this apparently improve reliability) |
We don't want integrations to sleep in our thread pool as it may exhaust the pool: Sleeping via asyncio is ok, but that requires the library to be changed to use asyncio. |
Yeah, that makes sense. |
e5c7902
to
55134c8
Compare
I decided to revert the changes to the I didn't want to rush the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @RyuzakiKK 👍
Proposed change
Bump
pyialarm
dependency to the version 2.2.0.Changes: RyuzakiKK/pyialarm@v1.9.0...v2.2.0
Type of change
(it said to choose just one box, but this is a dependency upgrade that fixes a bug...)
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: