Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actionable Persistent Notifications #121689

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jul 10, 2024

Proposed change

Allow persistent_notifications to have actionable buttons in the same style as the mobile apps.

image

The syntax is the same/similar as mobile apps, so that if persistent_notification is used in a notification group with mobile_apps, the desktop client can also trigger an action response.

When mobile apps trigger a response, they send a mobile_app_notification_action event, which didn't feel exactly right to use for a desktop client, so I chose to fire a persistent_notification_action event instead. I'm not sure what's the right choice, as this might make writing an automation to respond to the action slightly more difficult, as it may have to listen for two types of events, instead of just mobile_app_notification_action.

image

I also considered instead of sending an event, a service call could just be baked into the notification itself, so that the frontend could call that service when it was clicked, but this felt like it might be annoying as the setup would be completely different from how the mobile apps are used. Perhaps in the future this could be extended with optional actions directly defined in the notification (instead of having to write an automation to catch the event), but starting this simple for now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (notify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of notify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign notify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (persistent_notification) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of persistent_notification can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign persistent_notification Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@karwosts
Copy link
Contributor Author

Frontend: home-assistant/frontend#21361

@karwosts karwosts closed this Jul 10, 2024
@karwosts karwosts reopened this Jul 10, 2024
@frenck
Copy link
Member

frenck commented Jul 10, 2024

I think we need to discuss where this integration is going to, as this is part of core.

Including how this would work with things like the new notification entities and how to align with the apps.

This might be better fit for an architectural discussion first.

../Frenck

@frenck frenck marked this pull request as draft July 10, 2024 19:21
@karwosts
Copy link
Contributor Author

Opened in architecture (home-assistant/architecture#1110)

Closing for now.

@karwosts karwosts closed this Jul 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants