-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report webOS media player state #113774
Report webOS media player state #113774
Conversation
Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, need to handle _attr_assumed_state
and add tests coverage:
https://github.com/home-assistant/core/blob/dev/tests/components/webostv/test_media_player.py
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Would love to see this pr in the next major version of HA so I can finally turn on lights when pausing movies and turn off or dim when playing. |
Co-authored-by: Shay Levy <[email protected]>
I assume you forgot to mark the PR ready, PR looks good, thanks |
Proposed change
This exposes media player states (playing, paused, idle) on TVs with
recent versions of webOS when running any media player apps.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: