Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to service target #113753

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Add labels to service target #113753

merged 3 commits into from
Mar 18, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 18, 2024

Proposed change

Follow up of #110821, originally split out of #69996

Add support for targeting labels with services.

For example:

- service: light.turn_off
  target:
    label_id: christmas_decorations

WebSocket PR: home-assistant/home-assistant-js-websocket#383

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner March 18, 2024 18:08
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 18, 2024
@frenck frenck marked this pull request as draft March 18, 2024 20:34
@frenck frenck marked this pull request as ready for review March 18, 2024 20:46
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frenck 👍

@frenck frenck merged commit 167e66d into dev Mar 18, 2024
31 checks passed
@frenck frenck deleted the frenck-2024-0251 branch March 18, 2024 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core new-feature smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants