Add preview to Threshold config & option flow #111043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
I think perhaps add a printscreen to the PR description to visualize how it will look 👍 |
Done 🙂 |
frenck
added
smash
gjohansson-ST
requested changes
Mar 15, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jpbede
force-pushed
the
threshold-config-flow-preview
branch
from
c873458 to
3b5fccd
Compare
emontnemery
requested changes
May 8, 2024
Comment on lines
286
to
292
| # guard against the case where the thresholds are not set | ||
| if not hasattr(self, "_threshold_lower") and not hasattr( | ||
| self, "_threshold_upper" | ||
| ): | ||
| self._state_position = POSITION_UNKNOWN | ||
| self._state = None | ||
| return |
There was a problem hiding this comment.
Why is this case added? If it's only needed for preview, it should be possible to handle it in async_start_preview, if it's a bug fix it should be moved to a separate PR.
There was a problem hiding this comment.
Yea, that's just the case for preview. I moved this to async_start_preview. See the new PR as I screwed up the rebase
…nt#110475) * Update sensor.py for Hourly Rain Rates mm and in hourly_rain_rate from integration ecowitt has state class total_increasing, but its state is not strictly increasing * Update sensor.py format
* Add `open` state to LockEntity * Add tests * Fixes * Fix tests * strings and icons * Adjust demo open lock * Fix lock and tests * fix import * Fix strings * mute ruff * Change sequence * Sequence2 * Group on states * Fix ruff * Fix tests * Add more test cases * Sorting
…sistant#114599) * fix nibe_heatpump climate for models without cooling support * add test for set temperature with no cooling support * fixup use self._coil_setpoint_cool None * fixup add new test to explicitly test unsupported cooling
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
* Add better testing to vacuum platform * remove state strings * some of the MR comments * move MockVacuum * remove manifest extra * fix linting * fix other linting * Fix create entity calls * Format * remove create_entity * change to match notify --------- Co-authored-by: Martin Hjelmare <[email protected]>
…BluetoothDataUpdateCoordinator (home-assistant#117056)
…ant#117095) Avoid the gather call when there are no loaded config entries
* Catch AuthException in Husqvarna Automower * don't use getattr * raise ConfigEntryAuthFailed
…#117171) Fix ClimateService to rise ServiceValidationError for stack free logs
…sistant#109043) * Update device info when name changes * Entities now report themselves as being unavailable when the MotionMount is disconnected * Don't update device_info when name changes * Use `device_entry` property to update device name * Assert device is available Co-authored-by: Erik Montnemery <[email protected]> * Add missing import --------- Co-authored-by: Erik Montnemery <[email protected]>
* Add standard deviation calculation to group * Add missing bits --------- Co-authored-by: G Johansson <[email protected]>
…e-assistant-core into threshold-config-flow-preview
20 tasks
|
Sry everyone, I screwed up the rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the preview function to the Threshold helper config flow and option flow.
Context: The use of the upper, lower or both values together and their effects on the binary sensor are sometimes somewhat confusing (#110904) for users. With the preview, a user would see the result of their changes directly.
Frontend PR: home-assistant/frontend#19845
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: