Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiowebostv to 0.4.0 #110477

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

thecode
Copy link
Member

@thecode thecode commented Feb 13, 2024

Proposed change

Bump aiowebostv to 0.4.0: https://github.com/home-assistant-libs/aiowebostv/releases/tag/v0.4.0

Changes:

Diff: home-assistant-libs/aiowebostv@v0.3.3...v0.4.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

I think we don't support websockets v12 yet

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Websockets v12 isn't a requirement in production for the library as far as I know.

@MartinHjelmare
Copy link
Member

I also don't find anything in core that says we don't support websockets v12. Do you know?

@joostlek
Copy link
Member

I think I recently saw a telegram-bot-api bump that broke because of pinning websockets v12

@joostlek
Copy link
Member

joostlek commented Feb 13, 2024

hmm, I can't seem to find it, nvm my comment then

Probably because of the pinning it didn't work

@thecode
Copy link
Member Author

thecode commented Feb 13, 2024

Requirements for production are still at v10.3
https://github.com/home-assistant-libs/aiowebostv/blob/0da912d059acdd1910efb7ed890141a1f2b9b994/setup.py#L24

@MartinHjelmare MartinHjelmare merged commit 43bd05b into home-assistant:dev Feb 13, 2024
53 checks passed
astrandb pushed a commit to astrandb/core-akefork that referenced this pull request Feb 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@thecode thecode deleted the bump-aiowebostv branch January 11, 2025 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants