Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require specifying extended address in otbr WS API calls #108282

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jan 18, 2024

Proposed change

Require specifying border agent extended address in OTBR WS API calls

Frontend PR: home-assistant/frontend#21172

Rationale

This will allow making the otbr integration support multiple multiple config entries, thus allowing us to manage multiple OTBRs from the frontend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (otbr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of otbr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign otbr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 18, 2024 09:36
@emontnemery emontnemery marked this pull request as ready for review January 18, 2024 11:45
@MartinHjelmare MartinHjelmare marked this pull request as draft January 29, 2024 11:46
@emontnemery emontnemery force-pushed the otbr_ws_api_require_baid branch from abbfbaa to 5adbe90 Compare February 7, 2024 15:02
@emontnemery emontnemery changed the title Require specifying border agent ID in otbr WS API calls Require specifying extended address in otbr WS API calls Feb 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Apr 7, 2024
@agners agners removed the stale label Apr 8, 2024
@agners agners force-pushed the otbr_ws_api_require_baid branch from 5adbe90 to 2d6dd71 Compare May 28, 2024 09:04
@agners agners marked this pull request as ready for review May 28, 2024 09:20
@home-assistant home-assistant bot requested a review from MartinHjelmare May 28, 2024 09:20
@agners agners requested a review from edenhaus June 26, 2024 16:51
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emontnemery 👍

@edenhaus edenhaus merged commit 054242f into dev Jul 17, 2024
25 checks passed
@edenhaus edenhaus deleted the otbr_ws_api_require_baid branch July 17, 2024 07:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants