-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WS command sensor/numeric_device_classes #101257
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice,
Thnx @emontnemery 👍
Should we add developer docs for this new WS endpoint? |
I don't think it's needed, we don't document the WS API. Or is the existing sensor API documented? |
The websocket api is only partly documented and the WS sensor endpoint is not documented. So it's fine for me |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Please link the frontend PR that will use this command. |
Frontend PR is awaiting backend, backend is awaiting frontend 😄 |
Proposed change
Add WS command
sensor/numeric_device_classes
Needed by frontend PR home-assistant/frontend#18099
Background
If either of the following is true, frontend should plot a graph for sensor history:
The third check is enabled by the command added in this PR
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: