Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logos and icon for Vegetronix VegeHub #6047

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GhoweVege
Copy link

@GhoweVege GhoweVege commented Oct 31, 2024

Proposed change

I work for a company called Vegetronix. We want to add official support for connecting our VegeHub product to Home Assistant. I am almost finished with development of the integration, and I wanted to add logos and an icon to the HA brands so that I could link to them in the integration. I think I followed all guidelines, but please let me know if there's anything I need to change. Thanks!

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@home-assistant home-assistant bot added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 31, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds branding for a core integration, however, there is no Pull Request to our Core codebase linked up in this PR. Could you please point me to it?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft November 4, 2024 09:56
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@GhoweVege
Copy link
Author

Sorry, I'm new to all of this and I'm still learning the ropes. I've added the link in the PR in question.

My PR for the Core is still a work in progress, but I wasn't sure what order to do everything in, so I submitted logos/icons first. If those should be submitted later in the process, I'd be happy to retract my PR here until the integration is accepted into the Core.

Thanks!

@GhoweVege GhoweVege marked this pull request as ready for review November 7, 2024 20:48
@home-assistant home-assistant bot requested a review from frenck November 7, 2024 20:48
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Nov 8, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants