Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Festure/frontend dep upgrade #300

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

p-wunderlich
Copy link
Contributor

This fixed #248

@p-wunderlich p-wunderlich force-pushed the festure/frontend_dep_upgrade branch from eba1421 to 07aa42f Compare March 22, 2024 14:13
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 69.41%. Comparing base (c20e413) to head (2ccf8c3).
Report is 4 commits behind head on develop.

Files Patch % Lines
...t-angular/src/app/task/state/task.store-service.ts 54.54% 5 Missing ⚠️
...ngular/src/app/task/tasklist/tasklist.component.ts 50.00% 4 Missing ⚠️
...t-angular/src/app/shared/external-url.directive.ts 0.00% 2 Missing ⚠️
...t-angular/src/app/user/state/user.store-service.ts 75.00% 2 Missing ⚠️
...src/app/dataentry/state/dataentry.store-service.ts 75.00% 1 Missing ⚠️
...lar/src/app/process/state/process.store-service.ts 75.00% 1 Missing ⚠️
...r/src/app/task/sorter/sortable-column.component.ts 50.00% 1 Missing ⚠️
...asklist-angular/src/app/user/state/user.effects.ts 80.00% 1 Missing ⚠️
...pp/user/user-selection/user-selection.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
- Coverage    71.72%   69.41%   -2.32%     
===========================================
  Files           39       39              
  Lines          336      340       +4     
  Branches         6        6              
===========================================
- Hits           241      236       -5     
- Misses          95      104       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luchsamapparat
Copy link
Contributor

since most of the actual code changes have been made by me, I approve this with confidence

HighfiveGIF

@p-wunderlich p-wunderlich merged commit facb48a into develop Mar 25, 2024
1 of 3 checks passed
@p-wunderlich p-wunderlich deleted the festure/frontend_dep_upgrade branch March 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontend deps
2 participants