Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queries for task attribute names + values #843 #1019

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add queries for task attribute names + values #843 #1019

merged 1 commit into from
Aug 19, 2024

Conversation

p-wunderlich
Copy link
Contributor

@p-wunderlich p-wunderlich commented Jul 3, 2024 •
edited
Loading

Fixes #843

zambrovski
zambrovski requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@zambrovski zambrovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally it would work, but I rather doubt it is a good solution from the non-functional perspective. Mika's solution was an SQL snippet, why have you drop this approach? I would create a select to deliver a list of strings rather load all tasks with all search attributes and reduce inside the application.

In addition, I believe going over the payload in JPA might be a wrong way. We have special keys making sure that we create a path-like structure (attr1.attr2.attr3) and exclude some others. The results ends up in the element collection - and those distinct "keys" and "values" are of interest.

view/jpa/src/main/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewTaskService.kt Outdated Show resolved Hide resolved
view/jpa/src/main/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewTaskService.kt Outdated Show resolved Hide resolved
@zambrovski zambrovski added this to the 4.2.1 milestone Jul 9, 2024
@p-wunderlich p-wunderlich force-pushed the feature/843_provide_task_list_filter_criteria branch 4 times, most recently from 5d972bd to 14eaacb Compare July 15, 2024 11:22
@p-wunderlich p-wunderlich force-pushed the feature/843_provide_task_list_filter_criteria branch from 14eaacb to 2f31eac Compare July 15, 2024 14:12
@p-wunderlich
Copy link
Contributor Author

@zambrovski I fixed the comments, I use a JPA Query now + fixed also the handling of path like variables. Can you have a look please?

@zambrovski zambrovski added Type: enhancement New feature or request Status: In progress Assignee is working on this issue. Prio: Must This feature must be implemented in current milestone. labels Aug 19, 2024
@zambrovski zambrovski merged commit e67fb84 into develop Aug 19, 2024
7 checks passed
@zambrovski zambrovski deleted the feature/843_provide_task_list_filter_criteria branch August 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zambrovski zambrovski zambrovski approved these changes

Assignees

@p-wunderlich p-wunderlich

Labels
Prio: Must This feature must be implemented in current milestone. Status: In progress Assignee is working on this issue. Type: enhancement New feature or request
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

Provide task list filter criteria
2 participants
@p-wunderlich @zambrovski