Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate API and add deprications #406

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Conversation

zambrovski
Copy link
Member

  • adds a lot of deprecation to the old API, to be able to change stuff in the future
  • changes module structure (exposes camunda-bpm-data-api, camunda-bpm-data-c7)

@zambrovski zambrovski added this to the 1.5.0 milestone Nov 21, 2023
@zambrovski zambrovski added Type: enhancement New feature or request Type: dependencies Pull requests that update a dependency file Prio: Must Must feature for current milestone and removed Type: dependencies Pull requests that update a dependency file labels Nov 21, 2023
@zambrovski zambrovski self-assigned this Nov 21, 2023
@zambrovski zambrovski added the State: in progress Assignee is working on the issue. label Nov 21, 2023
@zambrovski zambrovski marked this pull request as draft November 21, 2023 15:18
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 273 lines in your changes are missing coverage. Please review.

Comparison is base (e9144bd) 77.74% compared to head (69bbeb3) 70.46%.
Report is 4 commits behind head on develop.

Files Patch % Lines
...unda/camunda/bpm/data/factory/C7VariableFactory.kt 0.00% 65 Missing ⚠️
...in/io/holunda/camunda/bpm/data/reader/MapReader.kt 0.00% 34 Missing ⚠️
...camunda/bpm/data/writer/ScopedVariableMapWriter.kt 0.00% 25 Missing ⚠️
...lunda/camunda/bpm/data/writer/VariableMapWriter.kt 38.46% 21 Missing and 3 partials ⚠️
...munda/bpm/data/reader/CaseServiceVariableReader.kt 47.05% 5 Missing and 4 partials ⚠️
...da/bpm/data/reader/RuntimeServiceVariableReader.kt 47.05% 5 Missing and 4 partials ⚠️
...munda/bpm/data/reader/TaskServiceVariableReader.kt 47.05% 5 Missing and 4 partials ⚠️
...munda/bpm/data/writer/CaseServiceVariableWriter.kt 52.63% 5 Missing and 4 partials ⚠️
...da/bpm/data/writer/RuntimeServiceVariableWriter.kt 52.63% 5 Missing and 4 partials ⚠️
...munda/bpm/data/writer/TaskServiceVariableWriter.kt 52.63% 5 Missing and 4 partials ⚠️
... and 14 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #406      +/-   ##
=============================================
- Coverage      77.74%   70.46%   -7.28%     
- Complexity       497      515      +18     
=============================================
  Files             76       80       +4     
  Lines           1339     1605     +266     
  Branches          83      148      +65     
=============================================
+ Hits            1041     1131      +90     
- Misses           245      406     +161     
- Partials          53       68      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Must Must feature for current milestone State: in progress Assignee is working on the issue. Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant