Add environment variable at startup #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Jun 24, 2024
pyviz_comms/__init__.py
Outdated
| @@ -30,6 +30,10 @@ def _jupyter_labextension_paths(): | |||
| except NameError: | |||
| get_ipython = None | |||
|
|
|||
| # Setting this so we can check the launched jupyter has pyviz_comms installed | |||
| if not (get_ipython and sys.argv[0].endswith('ipykernel_launcher.py')): | |||
There was a problem hiding this comment.
ipykernel_launcher.py file is what launches a notebook.
I will update the comments if we decide to proceed with the PR.
The name of the environment variable can change maybe to PYVIZ_COMMS_INSTALLED.
hoxbro
force-pushed
the
add_env_variable
branch
from
80bd6ab
to
24e0009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we can check in a notebook if the environment variable is set and give a warning if it is not.
Also available in the jupyter terminal.
