Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't remove ds_version yet #6417

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: Don't remove ds_version yet #6417

merged 2 commits into from
Oct 21, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 21, 2024

No description provided.

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (fbed3fb) to head (76ff889).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6417   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         323      323           
  Lines       68619    68620    +1     
=======================================
+ Hits        60729    60730    +1     
  Misses       7890     7890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from maximlt October 21, 2024 08:54
@hoxbro hoxbro enabled auto-merge (squash) October 21, 2024 09:33
@hoxbro hoxbro merged commit 4b668d3 into main Oct 21, 2024
14 checks passed
@hoxbro hoxbro deleted the version_ds_version branch October 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants