Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popup position and anchor #6414

Merged
merged 21 commits into from
Oct 23, 2024
Merged

Add popup position and anchor #6414

merged 21 commits into from
Oct 23, 2024
+484 −350

Commits on Oct 16, 2024

  1. add popup position and anchor

    @ahuang11
    ahuang11 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f4cabe6 View commit details
    Browse the repository at this point in the history

  2. tab

    @ahuang11
    ahuang11 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f667fe4 View commit details
    Browse the repository at this point in the history

  3. tab

    @ahuang11
    ahuang11 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e3f3204 View commit details
    Browse the repository at this point in the history

  4. add more test

    @ahuang11
    ahuang11 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    026ae1b View commit details
    Browse the repository at this point in the history

  5. add test and fix bug

    @ahuang11
    ahuang11 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    897cae2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'main' into popup_position_anchor

    @ahuang11
    ahuang11 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ea158fe View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Apply suggestions from code review 

    Commit suggestions

Co-authored-by: Simon Høxbro Hansen <[email protected]>
    @ahuang11 @hoxbro
    ahuang11 and hoxbro authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a75a438 View commit details
    Browse the repository at this point in the history

  2. clean up logic

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0f87296 View commit details
    Browse the repository at this point in the history

  3. change default anchors

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a38a81a View commit details
    Browse the repository at this point in the history

  4. add parametrized tests

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fecdf6b View commit details
    Browse the repository at this point in the history

  5. simplify tests and fix polygons

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8c0bacc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into popup_position_anchor

    @ahuang11
    ahuang11 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c88bd6d View commit details
    Browse the repository at this point in the history

  7. move expect before

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6ae2d02 View commit details
    Browse the repository at this point in the history

  8. fix other test

    @ahuang11
    ahuang11 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2488bb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Simon Høxbro Hansen <[email protected]>
    @ahuang11 @hoxbro
    ahuang11 and hoxbro authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    632d7ff View commit details
    Browse the repository at this point in the history

  2. into class

    @ahuang11
    ahuang11 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5612bde View commit details
    Browse the repository at this point in the history

  3. fix tests

    @ahuang11
    ahuang11 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9cee665 View commit details
    Browse the repository at this point in the history

  4. add a buffer

    @ahuang11
    ahuang11 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2b90cfc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into popup_position_anchor

    @ahuang11
    ahuang11 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0d399f6 View commit details
    Browse the repository at this point in the history

  6. add atol

    @ahuang11
    ahuang11 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9844a3b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. small changes

    @hoxbro
    hoxbro committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ab04349 View commit details
    Browse the repository at this point in the history