Ensure proper cleanup of stream subscribers #6389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
fix_stream_cleanup
branch
from
940af68
to
5cbed44
Compare
philippjfr
changed the title
philippjfr
commented
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6389 +/- ##
==========================================
+ Coverage 88.48% 88.50% +0.01%
==========================================
Files 323 323
Lines 68459 68531 +72
==========================================
+ Hits 60579 60650 +71
- Misses 7880 7881 +1 ☔ View full report in Codecov by Sentry. |
hoxbro
reviewed
Sep 27, 2024
|
@TheoMathurin No, watchers are separate, this only deals with subscribers installed by the plot itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream subscribers were not being properly cleaned up correctly, because we were only cleaning up linked streams. This would result in keeping references to old plots being kept around preventing garbage collection and also mean that if you reused a Stream you would continue to pointlessly update discarded plots.