Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruff in pre-commit and report panel comms in show_versions #5853

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 9, 2023

This PR does two things:

  1. Add information about panel comms in hv.show_versions.
  2. Update Ruff in pre-commit. The changes are:
    a) Conversion of list(...)[0] to next(iter(...))
    b) str.format to f-strings.
    c) Also converted these lines [v for _ in range(len(list(data.values())[0]))] to [v] * len(next(iter(data.values()))) in 2e21eaa
    d) Manual fixing PLR1714 and F811.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #5853 (3ebb07b) into main (5ba6537) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 64.93%.

@@           Coverage Diff           @@
##             main    #5853   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         309      309           
  Lines       63915    63920    +5     
=======================================
+ Hits        56396    56402    +6     
+ Misses       7519     7518    -1     
Flag Coverage Δ
ui-tests 23.36% <7.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/core/data/__init__.py 86.53% <0.00%> (ø)
holoviews/core/data/multipath.py 86.32% <0.00%> (ø)
holoviews/core/data/xarray.py 89.41% <ø> (ø)
holoviews/core/ndmapping.py 79.88% <0.00%> (ø)
holoviews/core/options.py 82.53% <0.00%> (ø)
holoviews/core/pprint.py 75.39% <0.00%> (ø)
holoviews/operation/datashader.py 83.80% <0.00%> (ø)
holoviews/plotting/mpl/chart.py 64.07% <ø> (ø)
holoviews/plotting/renderer.py 71.78% <0.00%> (ø)
holoviews/plotting/util.py 68.78% <0.00%> (ø)
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[skip ci]
@hoxbro hoxbro merged commit fb16727 into main Aug 16, 2023
@hoxbro hoxbro deleted the maint branch August 16, 2023 06:30
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants