-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Legend support for Layout and add documentation #5852
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5852 +/- ##
==========================================
+ Coverage 88.23% 88.26% +0.02%
==========================================
Files 309 309
Lines 63915 63939 +24
==========================================
+ Hits 56396 56436 +40
+ Misses 7519 7503 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3ff167d
to
003eed6
Compare
003eed6
to
6bff462
Compare
b48f393
to
1484cf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I have changed import holoviews as hv
import hvplot.pandas
import numpy as np
import pandas as pd
df = pd.DataFrame(np.arange(10)[:, None] * np.array([1, 2, 3]), columns=list("ABC"))
plot = (df.hvplot().opts(show_legend=False) + df.hvplot() + df.hvplot() + df.hvplot()).cols(2)
plot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes seem reasonable to me. Happy to see this merged.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #5833
This PR I want to implement the following:
show_legends
andlegend_position
to.opts
for a Layout Plot. (Note thatshow_legends
is plural)sync_legends
andshow_legends
in a Layout plot.util.select_legends
.util.select_legends
toutil.show_legends
.Example of show_legends: