Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_mathjax and set it and inline to False #5729

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 26, 2023

Follow up to holoviz/panel#4895 and implements #5730

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #5729 (994d4bb) into main (f4c4c12) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5729      +/-   ##
==========================================
- Coverage   88.24%   88.23%   -0.01%     
==========================================
  Files         304      304              
  Lines       62680    62683       +3     
==========================================
+ Hits        55309    55310       +1     
- Misses       7371     7373       +2     
Impacted Files Coverage Δ
holoviews/ipython/__init__.py 75.77% <100.00%> (+0.15%) ⬆️
holoviews/plotting/renderer.py 71.78% <100.00%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro added this to the 1.16.1 milestone May 26, 2023
@hoxbro hoxbro changed the title Enable MathJax by default Add enable_mathJax and set it and inline to False Jun 2, 2023
@hoxbro hoxbro mentioned this pull request Jun 2, 2023
3 tasks
@hoxbro hoxbro changed the title Add enable_mathJax and set it and inline to False Add enable_mathjax and set it and inline to False Jun 2, 2023
@hoxbro hoxbro requested a review from philippjfr June 2, 2023 14:28
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hoxbro hoxbro merged commit 321d8ea into main Jun 2, 2023
@hoxbro hoxbro deleted the add_enable_mathjax branch June 2, 2023 14:56
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants