-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Volume Imaging Ex for use of newly released panel-neuroglancer
#486
Conversation
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool example!
I was trigger-happy and merged this PR before the last commit was finished running through the CI because it only contained minor wording style changes based on the review feedback, and since the CI was passing prior to that commit. But…. I think that messed up the github workflows chain of dependencies which maybe expects that the PR CI finished before merging because now the deployed main website does not contain the wording updates made in the last commit of the PR and the test+build+deploy action is failing. IMO, it’s not urgent to address, but I wanted to document that deployed site does not match the latest (squashed) commit that has now been merged into main. I’m tempted to click ‘Revert’ on this merged PR page and see if that allows the PR CI to rerun in full successful and then I can remerge the PR and wipe everything under the rug, but I’m worried that will break things on main/deployed website somehow and with some of our more infra-familiar team away for holidays, I have a very low risk tolerance so I think things will stay as they are for a few more days. lesson learned |
Resolves #481
The primary approaches have been reworked around the installable package panel-neuroglancer, rather than depending on a in-notebook coded implementation.
The in-notebook coded implementation was retained but reframed to be about understanding the underlying implementation and about further customization, with added some explanation of the machinery.