Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Volume Imaging Ex for use of newly released panel-neuroglancer #486

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Dec 17, 2024

Resolves #481

The primary approaches have been reworked around the installable package panel-neuroglancer, rather than depending on a in-notebook coded implementation.

The in-notebook coded implementation was retained but reframed to be about understanding the underlying implementation and about further customization, with added some explanation of the machinery.

CustomNeuroglancer


⚠️ It's already known that the in-notebook apps are not rendering properly on the docs site or deployment, and this should NOT block review approval.

image

image

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool example!

volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
@droumis droumis merged commit 7247aaa into main Dec 18, 2024
3 of 4 checks passed
@droumis
Copy link
Contributor Author

droumis commented Dec 18, 2024

I was trigger-happy and merged this PR before the last commit was finished running through the CI because it only contained minor wording style changes based on the review feedback, and since the CI was passing prior to that commit.

But…. I think that messed up the github workflows chain of dependencies which maybe expects that the PR CI finished before merging because now the deployed main website does not contain the wording updates made in the last commit of the PR and the test+build+deploy action is failing.

IMO, it’s not urgent to address, but I wanted to document that deployed site does not match the latest (squashed) commit that has now been merged into main. I’m tempted to click ‘Revert’ on this merged PR page and see if that allows the PR CI to rerun in full successful and then I can remerge the PR and wipe everything under the rug, but I’m worried that will break things on main/deployed website somehow and with some of our more infra-familiar team away for holidays, I have a very low risk tolerance so I think things will stay as they are for a few more days.

lesson learned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Volumetric Imaging
2 participants