Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumetric imaging example #454

Merged
merged 42 commits into from
Dec 10, 2024
Merged

volumetric imaging example #454

merged 42 commits into from
Dec 10, 2024

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Nov 22, 2024

volumetric_imaging_header

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

@droumis droumis marked this pull request as ready for review December 3, 2024 23:03
@droumis droumis requested a review from maximlt December 3, 2024 23:04
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main concern I have with this example at the moment is that it's hard to demonstrate its capabilities:

  • Deploying it as a read-only notebook is likely to fail (see comment in the project file)
  • The NeuroGlancer views aren't displayed on the website (see screenshots below), which makes it look quite broken

@droumis how about:

  • Replacing the actual views in the notebook with screenshots/gifs? (unless the underlying issue can be fixed, I haven't look at all into it)
  • Deploying the example as a Panel app?

Chrome:
image

Firefox:
image

volumetric_imaging/anaconda-project.yml Outdated Show resolved Hide resolved
volumetric_imaging/anaconda-project.yml Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/volumetric_imaging.ipynb Outdated Show resolved Hide resolved
volumetric_imaging/anaconda-project.yml Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maximlt
Copy link
Contributor

maximlt commented Dec 10, 2024

@droumis I made a few changes in 6b8e6c7:

@maximlt maximlt merged commit 266ef05 into main Dec 10, 2024
9 checks passed
@jbednar
Copy link
Contributor

jbednar commented Dec 11, 2024

Thanks for this great example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants