Replace the use of stamen tiles in the repo #451

Azaya89 · 2024-11-21T16:56:38Z

closes Replace broken Stamen tiles #292

The use of stamen tiles in the census example will be done under #430

github-actions · 2024-11-21T17:24:32Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

ml_annotators/ml_annotators.ipynb

maximlt · 2024-11-21T20:49:56Z

It'd be nice if you could post screenshots of the new plots so we can see if the basemap colors don't confict too much with the data colors.

Azaya89 · 2024-11-22T16:17:12Z

Landsat Old

Landsat new

Ml_annotator old

Ml_annotator new

Ship traffic old

Ship traffic new

maximlt · 2024-11-22T16:44:06Z

Thanks @Azaya89! The comparison with the old maps doesn't really apply as the Stamen maps can no longer be loaded. You can visit for example the ML Annotator example and verify in your browser that the requests made to get the Stamen tiles fail. This example seems to have an overlay of tiles (ESRI * Stamen).

github-actions · 2024-11-22T16:45:23Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

ship_traffic/ship_traffic.ipynb

Azaya89 · 2024-11-27T16:30:29Z

Datashader dashboard now

Ship traffic now

ML_annotators now

When you zoom in, the labels also update dynamically.
@maximlt

github-actions · 2024-11-27T16:53:32Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

maximlt

Nice good progress :) !

I can see Census also use StamenLabels in two places, do you plan to update it too?

landsat/landsat.ipynb

ship_traffic/ship_traffic.ipynb

maximlt · 2024-11-27T18:00:02Z

ship_traffic/ship_traffic.ipynb

@@ -509,7 +514,7 @@
    "sopts         = dict(start=0, end=1, sizing_mode='stretch_width')\n",
    "map_opacity   = pn.widgets.FloatSlider(value=0.7, name=\"Map opacity\",   **sopts)\n",
    "data_opacity  = pn.widgets.FloatSlider(value=1.0, name=\"Data opacity\",  **sopts)\n",
-    "label_opacity = pn.widgets.FloatSlider(value=0.9, name=\"Label opacity\", **sopts)\n",
+    "label_opacity = pn.widgets.FloatSlider(value=0.3, name=\"Label opacity\", **sopts)\n",


The labels are a bit hard to read on this map. Is it because they're too transparent?

Agreed. Maybe the CartoDB.VoyagerOnlyLabels would show up better? I haven't tried it myself.

Also, what's up with the data rendering resolution? :-)

Also, what's up with the data rendering resolution? :-)

It's a screenshot from the website after zooming in :)

The labels are a bit hard to read on this map. Is it because they're too transparent?

Yes, it's the map opacity. I've put the default back to 0.7 now

PositronOnly

VoyagerOnly

I can't spot a difference between those two; are you sure they are different?

I'm sure. I too, can't see any visual difference.

maximlt · 2024-11-27T18:01:55Z

datashader_dashboard/anaconda-project-lock.yml

Relocking can have some unwanted consequences, specially for projects like this that are stuck in the past. Can you make sure the notebook run fine locally please? (it might pass the tests fine but still be somewhat in a broken state).

Can you remind me why that project is stuck in the past? IIRC it's a quite simple project that I'd think was easy to update, but I don't know the constraints here.

The NG SDG grant wasn't enough funding to update all the examples so we haven't touch them all, like this one. PRs are welcome!

Can you make sure the notebook run fine locally please? (it might pass the tests fine but still be somewhat in a broken state).

It ran locally fine before I pushed the commit. I usually do all the necessary pre-checks after re-locking to make sure nothing has broken.

Can you remind me why that project is stuck in the past? IIRC it's a quite simple project that I'd think was easy to update, but I don't know the constraints here.

I can open separate PRs for updating the example, but I think we should finish up the tiles replacements here first?

Can you make sure the notebook run fine locally please? (it might pass the tests fine but still be somewhat in a broken state).

It ran locally fine before I pushed the commit. I usually do all the necessary pre-checks after re-locking to make sure nothing has broken.

Nice, perfect! 👍

Can you remind me why that project is stuck in the past? IIRC it's a quite simple project that I'd think was easy to update, but I don't know the constraints here.

I can open separate PRs for updating the example, but I think we should finish up the tiles replacements here first?

Updating the examples is an endless business :) datashader_dashboard was assigned priority 3 on our NF SDG sheet (from 1 to 6) and we didn't have enough time to get there (we updated almost half of them, not bad!). It's also special as @jbednar has an old PR that should be incorporated (#67).

My take is:

let's focus on wrapping up all the work we've started part of the NF SDG

additionally, let's complete Plan to V2 #383 that includes work I started a long time ago (making all the examples "compliant", still 2 on that list)

once we're done with that, let's advertise it, I'd like to see these numbers increase https://holoviz.goatcounter.com/?hl-period=month&period-start=2024-10-28&period-end=2024-11-28&filter=%2Fexamples.holoviz.org&daily=off

After that, let's take a breather and later re-assign priorities. We're a much larger team compared to when I joined, others could get involved more to help maintain the examples.

sounds good to me!

Ah, I see. By "stuck in the past" I thought you meant something was keeping it there other than the length of our to-do list. That's fine!

Azaya89 · 2024-11-28T10:33:51Z

Nice good progress :) !

I can see Census also use StamenLabels in two places, do you plan to update it too?

Sure.

github-actions · 2024-11-28T17:25:14Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

ship_traffic/ship_traffic.ipynb

github-actions · 2024-11-29T14:55:21Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

github-actions · 2024-11-29T18:00:16Z

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

maximlt

LGTM!

jbednar · 2024-11-29T19:41:47Z

Thanks for fixing this problem!

If we're going to use the PositronOnly labels throughout our examples, should we add them to HoloViews/GeoViews tile sources so that we don't have to "import xyzservices.providers as xyz" and have that dependency? Fine if not, but if others agree, please file an issue to move in that direction in subsequent releases.

Azaya89 requested a review from hoxbro November 21, 2024 16:56

Azaya89 self-assigned this Nov 21, 2024

maximlt reviewed Nov 21, 2024

View reviewed changes

ml_annotators/ml_annotators.ipynb Outdated Show resolved Hide resolved

Azaya89 added 2 commits November 22, 2024 12:56

replaced the use of stamen tiles

dd3338a

changed label type and opacity for ship traffic

5406d3d

Azaya89 force-pushed the patch-stamen292 branch from 6a2968f to 5406d3d Compare November 22, 2024 16:12

maximlt reviewed Nov 22, 2024

View reviewed changes

ship_traffic/ship_traffic.ipynb Outdated Show resolved Hide resolved

Azaya89 added 2 commits November 27, 2024 17:14

updated lock files to add xyzservices for datashader_dashboard

7fb68d2

updated files to use CartoDB tiles

108abc1

maximlt reviewed Nov 27, 2024

View reviewed changes

changed tiles and labels for ship traffic and landsat

daf6443

Azaya89 commented Nov 29, 2024

View reviewed changes

ship_traffic/ship_traffic.ipynb Outdated Show resolved Hide resolved

Update ship_traffic.ipynb

7c51995

Azaya89 requested a review from maximlt November 29, 2024 14:46

Merge branch 'main' into patch-stamen292

a479aa3

maximlt approved these changes Nov 29, 2024

View reviewed changes

maximlt merged commit 83352b0 into main Nov 29, 2024
21 checks passed

jbednar deleted the patch-stamen292 branch November 29, 2024 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace the use of stamen tiles in the repo #451

Replace the use of stamen tiles in the repo #451

Azaya89 commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

maximlt commented Nov 21, 2024

Azaya89 commented Nov 22, 2024

maximlt commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024

Azaya89 commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

maximlt left a comment

maximlt Nov 27, 2024

jbednar Nov 28, 2024

maximlt Nov 28, 2024

Azaya89 Nov 28, 2024

jbednar Nov 28, 2024

Azaya89 Nov 28, 2024

maximlt Nov 27, 2024

jbednar Nov 28, 2024

maximlt Nov 28, 2024

Azaya89 Nov 28, 2024

Azaya89 Nov 28, 2024

maximlt Nov 28, 2024

maximlt Nov 28, 2024 •

edited

Loading

Azaya89 Nov 28, 2024

jbednar Nov 28, 2024

Azaya89 commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

maximlt left a comment

jbednar commented Nov 29, 2024

Replace the use of stamen tiles in the repo #451

Replace the use of stamen tiles in the repo #451

Conversation

Azaya89 commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

maximlt commented Nov 21, 2024

Azaya89 commented Nov 22, 2024

Landsat Old

Landsat new

Ml_annotator old

Ml_annotator new

Ship traffic old

Ship traffic new

maximlt commented Nov 22, 2024 • edited Loading

github-actions bot commented Nov 22, 2024

Azaya89 commented Nov 27, 2024

Datashader dashboard now

Ship traffic now

ML_annotators now

github-actions bot commented Nov 27, 2024

maximlt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PositronOnly

VoyagerOnly

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maximlt Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Azaya89 commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

maximlt left a comment

Choose a reason for hiding this comment

jbednar commented Nov 29, 2024

maximlt commented Nov 22, 2024 •

edited

Loading

maximlt Nov 28, 2024 •

edited

Loading