Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the contributing section #355

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Updated the contributing section #355

merged 3 commits into from
Mar 20, 2024

Conversation

Azaya89
Copy link
Collaborator

@Azaya89 Azaya89 commented Jan 30, 2024 •
edited
Loading

This PR modifies the Contributing section of the repository to add instructions on how to update an existing project.

@Azaya89 Azaya89 requested a review from maximlt January 30, 2024 19:44
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

maximlt
maximlt reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I think we can wait a little before merging, I'm sure you'll have more to add when you will really update your next project. I also think it'd be good to get @jtao1 's feedback (later), he may suggest other steps to add or updates.

@maximlt maximlt marked this pull request as draft February 1, 2024 18:59
@Azaya89
Copy link
Collaborator Author

Azaya89 commented Feb 2, 2024

Thanks for your PR! I think we can wait a little before merging, I'm sure you'll have more to add when you will really update your next project. I also think it'd be good to get @jtao1 's feedback (later), he may suggest other steps to add or updates.

I agree. I'm already seeing more steps that need to be added :)

@Azaya89 Azaya89 added the NF SDG NumFocus Software Development Grant 2024 label Feb 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@Azaya89 Azaya89 requested a review from maximlt March 8, 2024 20:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@Azaya89 Azaya89 self-assigned this Mar 11, 2024
@Azaya89 Azaya89 marked this pull request as ready for review March 12, 2024 16:44
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

maximlt
maximlt requested changes Mar 14, 2024
View reviewed changes
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
doc/contributing.md Show resolved Hide resolved
@Azaya89 Azaya89 requested a review from maximlt March 14, 2024 22:05
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

maximlt
maximlt approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maximlt maximlt merged commit fa96c4d into main Mar 20, 2024
7 checks passed
@Azaya89 Azaya89 deleted the contrib-docs branch March 21, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximlt maximlt maximlt approved these changes

Assignees

@Azaya89 Azaya89

Labels
NF SDG NumFocus Software Development Grant 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azaya89 @maximlt