Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable-diffusion example using panel #254

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

sandhujasmine
Copy link
Collaborator

@sandhujasmine sandhujasmine commented Jan 31, 2023

Outstanding items:

  • working through M1;
  • test on CPU only
  • review, get feedback, cleanup (repeat)
  • history of thumbnails should be clickable. Thanks @philippjfr & @maximlt - still working on getting the updates in.
  • Verify it works on the Mac using CPUs. It currently won't work without GPUs so needs to be updated to check for it. Notebook runs on the mac but does not produce images (couldn't get accelerate package working yet)
  • Option to have side bar squashed by default (Panel#2410).

Nice to have / future work:

- [ ] Still seeing it stop on the GPU (investigate the collected data to see if we have a memory issue?) Wont fix (This is intermittent, running on a dev environment. Not sure this is a real problem)
- [ ] create / share punchlist of items before we can mark this done. Probably won't deploy on GPUs so leave for now

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments, before I can point you to the updated docs :)

stable-diffusion/.projectignore Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/anaconda-project.yml Outdated Show resolved Hide resolved
stable-diffusion/stable-diffusion.ipynb Outdated Show resolved Hide resolved
@maximlt
Copy link
Contributor

maximlt commented May 2, 2023

@sandhujasmine I did a few changes on the branch, mostly to get the project validated and to get it to be tested and built using the macos runner, that has more memory than the ubuntu ones which were failing because of that.

@maximlt maximlt mentioned this pull request Apr 21, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants