Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize penguins example and compliance #213

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Dec 19, 2022

  • Made plots height responsive
  • Switched to FastListTemplate
  • Fix selection on violin
  • Clean up sidebar
  • Add clear button

Screen Shot 2022-12-19 at 02 03 55

@hoxbro
Copy link
Contributor

hoxbro commented Dec 19, 2022

Just noting, I can't use lasso select on the current Palmer Panguins

@MarcSkovMadsen
Copy link
Collaborator

The issue a reported bug with HoloViews on this.

@philippjfr
Copy link
Contributor Author

Works fine in the version I have checked in here.

@maximlt
Copy link
Contributor

maximlt commented Dec 19, 2022

Just noting that there was indeed an issue opened on HoloViews on this, and it was found that this was because the element used was Scatter instead of Points.

@maximlt maximlt changed the title Modernize penguins example Modernize penguins example and compliance Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt merged commit e7d2a38 into main Nov 2, 2023
9 checks passed
@maximlt maximlt deleted the penguins_modernize branch October 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants