Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoloViews dotplot and umap elements #17

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

HoloViews dotplot and umap elements #17

wants to merge 9 commits into from

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Nov 26, 2024

HoloViz-ifying the scanpy clustering tutorial and making:

WIP POC:

  • HoloViews anndata Interface
  • HoloViews DotPlot Element
  • HoloViews/Panel Dim Reduction (PCA, UMAP) App

UPDATE:

  • started a new hv-anndata repo

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

Violin

image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

Scatter

image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

Variance ratio

image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

PCA

image image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

UMAP

image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

UMAP Leiden graph-clustering

image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

UMAP QC metrics

image image image image

@droumis
Copy link
Contributor Author

droumis commented Nov 28, 2024

UMAP cell-type classification labels

image image

@jbednar
Copy link
Collaborator

jbednar commented Dec 2, 2024

Nice! The results seem quite different in this case between Matplotlib and Bokeh:
image

@droumis
Copy link
Contributor Author

droumis commented Dec 3, 2024

Nice! The results seem quite different in this case between Matplotlib and Bokeh:

Yea, honestly, I don't know what's going on with the coloring. I'm not sure this particular plot is improved with rasterization.. it is suboptimal to have to play with spreading.

@jbednar
Copy link
Collaborator

jbednar commented Dec 3, 2024

Yea, honestly, I don't know what's going on with the coloring. I'm not sure this particular plot is improved with rasterization.. it is suboptimal to have to play with spreading.

If that coloring difference isn't deliberate, it seems like a bug that should be addressed. I'd be happy to have hvplot respect the size argument (translating it to a spread value) so that people wouldn't have to play around with spreading.

@droumis
Copy link
Contributor Author

droumis commented Dec 5, 2024

Highly variable genes

image

image

@droumis
Copy link
Contributor Author

droumis commented Dec 13, 2024

If that coloring difference isn't deliberate, it seems like a bug that should be addressed.

fixed the coloring issue.. it wasn't using the first two colors of the cmap for the two categories so I just limit the cmap to the first two colors and that resolves it.

@jbednar
Copy link
Collaborator

jbednar commented Dec 13, 2024

fixed the coloring issue.. it wasn't using the first two colors of the cmap for the two categories so I just limit the cmap to the first two colors and that resolves it.

That sounds like a workaround, with a bug that still needs fixing. What it sounds like is that it is treating the list of colors as a colormap (which is sampled at equal intervals due to its continuous nature) rather than as a color key or color cycle (which are taken in order due to their discrete nature). Definitely should not be confusing those usages! So unless I'm confused, you shouldn't be using cmap, you should be using a color key or color cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants