feat: set tracing to output to stderr #138

cdunster · 2024-10-21T17:12:35Z

Summary

As reported in issue #137, the output of the url command is supposed to just be the connection_url. This PR sets the tracing output to stderr to keep stdout clean of logs.

Closes #137

TODO:

Add some tests to make sure the url command outputs correctly on stdout.
CHANGELOG(s) updated with appropriate info

Previously, the error was caught, printed, and ignored so the command always exits with a success (exit code `0`).

crates/lair_keystore/src/bin/lair-keystore-bin/main.rs

neonphog

nice 👍

feat: set tracing to output to stderr

9654b4a

cdunster self-assigned this Oct 21, 2024

cdunster added 3 commits October 22, 2024 15:21

feat: make lair-keystore bin fail if encounters an error

b5dd61c

Previously, the error was caught, printed, and ignored so the command always exits with a success (exit code `0`).

test: add integration test for the url command

6324216

docs: update the changelog

e624590

cdunster marked this pull request as ready for review October 22, 2024 13:26

cdunster requested review from neonphog and a team October 22, 2024 13:26

cdunster commented Oct 22, 2024

View reviewed changes

crates/lair_keystore/src/bin/lair-keystore-bin/main.rs Show resolved Hide resolved

neonphog approved these changes Oct 22, 2024

View reviewed changes

cdunster merged commit 462e1e5 into main Oct 22, 2024
14 checks passed

cdunster deleted the tracing-to-stderr branch October 22, 2024 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: set tracing to output to stderr #138

feat: set tracing to output to stderr #138

cdunster commented Oct 21, 2024 •

edited

Loading

neonphog left a comment

feat: set tracing to output to stderr #138

feat: set tracing to output to stderr #138

Conversation

cdunster commented Oct 21, 2024 • edited Loading

Summary

TODO:

neonphog left a comment

Choose a reason for hiding this comment

cdunster commented Oct 21, 2024 •

edited

Loading