Correctly handle spaces in file paths #334
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
install_dotfiles()
inbootstrap
treats the output offind
as a list rather than an array, paths with spaces in them will break. The simplest solution is to change the Internal Field Separator to a newline, as it is extremely unlikely that any filenames will contain that character.Alternatively, the result of
find
could be put into an array, as demonstrated by this answer, but this seems like a reasonable fix for the vast majority of cases.