Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle spaces in file paths #334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wdn
Copy link

@wdn wdn commented Aug 19, 2020

Since install_dotfiles() in bootstrap treats the output of find as a list rather than an array, paths with spaces in them will break. The simplest solution is to change the Internal Field Separator to a newline, as it is extremely unlikely that any filenames will contain that character.

Alternatively, the result of find could be put into an array, as demonstrated by this answer, but this seems like a reasonable fix for the vast majority of cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant