Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Socket SSE example #5

Merged
merged 1 commit into from
May 7, 2020
Merged

Bulk Socket SSE example #5

merged 1 commit into from
May 7, 2020

Conversation

ImVexed
Copy link
Contributor

@ImVexed ImVexed commented May 7, 2020

It's nowhere near complete, and we can play with things in my fork if we'd like to keep this repo clean, but this is roughly a setup that repro's the error from #4

Currently there's 3 issues:

  • Submit Queue doesn't reset, you'll eventually run out of entries
  • For some reason if you start more than 10 or so clients, you'll get unexpected EOF, not sure why, might be in the Hijack() logic
  • Some sockets still get their data overwritten on receive

Copy link
Owner

@hodgesds hodgesds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still working on getting wrap around to work properly.

@hodgesds hodgesds merged commit faae52b into hodgesds:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants