Removing react from bundle per facebook/react#13991 (#191)

hodgef · Sep 7, 2019 · 0265ef8 · 0265ef8
1 parent 8ab861b
commit 0265ef8
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 6 deletions.
diff --git a/build/css/index.css b/build/css/index.css
diff --git a/build/index.js b/build/index.js
diff --git a/build/index.js.map b/build/index.js.map
diff --git a/config/webpack.config.js b/config/webpack.config.js
@@ -162,6 +162,10 @@ module.exports = function(webpackEnv) {
         ? 'source-map'
         : false
       : isEnvDevelopment && 'cheap-module-source-map',
+    externals: {
+      'react': 'react',
+      'react-dom' : 'reactDOM'
+    },
     // These are the "entry points" to our application.
     // This means they will be the "root" imports that are included in JS bundle.
     entry: isEnvProduction ? [paths.appLibIndexJs] : [

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-simple-keyboard",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "React.js Virtual Keyboard",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -106,6 +106,10 @@
     "webpack-manifest-plugin": "2.0.4",
     "workbox-webpack-plugin": "4.3.1"
   },
+  "peerDependencies": {
+    "react": "^16.9.0",
+    "react-dom": "^16.9.0"
+  },
   "eslintConfig": {
     "extends": "react-app"
   },