Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty container elements for accessibility #419

Merged
merged 37 commits into from
Mar 11, 2024

Conversation

LDubya
Copy link
Contributor

@LDubya LDubya commented Mar 5, 2024

This pull request remediates the issue where some menu bar and team member project list containers are empty, totaling 274 occurrences on 237 pages, in order to conform to WCAG Success Criteria A 1.3.1: Info and Relationships.

The fix is to ensure that

    elements aren't rendered onto the page if they don't have any
  • elements to show.

    Liquid templating language makes it necessary to use double iteration in _layouts/member.html. Storing the list output using the {% capture %} tag and then only outputting the

      if the list isn't empty would be ideal, but unfortunately the {% capture %} tag ends up capturing some kind of whitespace, even when {%- -%} is used to trim whitespace.

@lchoy lchoy merged commit 7d3b1b3 into hms-dbmi:main Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants