-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty container elements for accessibility #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepting suggested changes contributing proper spellings of HuBMAP and CCF Co-authored-by: L Choy <[email protected]>
… (WCAG A 1.3.1: Info and Relationships)
…mber has no projects listed
lchoy
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request remediates the issue where some menu bar and team member project list containers are empty, totaling 274 occurrences on 237 pages, in order to conform to WCAG Success Criteria A 1.3.1: Info and Relationships.
The fix is to ensure that
elements aren't rendered onto the page if they don't have any- elements to show.
Liquid templating language makes it necessary to use double iteration in _layouts/member.html. Storing the list output using the {% capture %} tag and then only outputting the
if the list isn't empty would be ideal, but unfortunately the {% capture %} tag ends up capturing some kind of whitespace, even when {%- -%} is used to trim whitespace.