Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIPR-1378] Some refactoring to support Pages to simplify UserAnswers. Store HonestyDeclarationPage value on submission. #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MIPR-1378] Some refactoring to support Pages to simplify UserAnswers. Store HonestyDeclarationPage value on submission. #15

wants to merge 1 commit into from

Conversation

MJCallahanPage
Copy link
Contributor

Notes:

  • I think it makes sense to create Page objects to represent the Page Key and Values to be stored. So there's a refactor here to start that transition
  • It also means that IncomeTaxSessionKeys will be more accurately only contain the keys that we actually store in the Session Cookie
  • I added some backwards compatibility to temporarily support the reasonableExcuse still being stored in the Session Cookie for now, but this can be removed once we store the value in UserAnswers.

@platops-pr-bot
Copy link

@MJCallahanPage
[MIPR-1378] Some refactoring to support Pages to simplify UserAnswers…
7401ed6 
…. Store HonestyDeclarationPage value on submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadinJ nadinJ nadinJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MJCallahanPage @platops-pr-bot @nadinJ