Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move document urls outside the feature disable pages toggle. #3717

Merged
merged 9 commits into from
Oct 21, 2024
Merged

move document urls outside the feature disable pages toggle. #3717

merged 9 commits into from
Oct 21, 2024

Conversation

velimd
Copy link
Contributor

@velimd velimd commented Oct 11, 2024

JIRA link

https://tools.hmcts.net/jira/browse/DTSCCI-995

Change description

Extract the urls related to document downloads outside the feature disable pages.

Work checklist

  • Unit tests added where applicable
  • Route tests added for new pages
  • New pages included in a11y tests
  • Task list and task completeness checks updated
  • Check and send page updated
  • Routes, page content and page flows of new features are toggled
  • UI changes look good on mobile
  • Required Google Analytics events are being sent

Developer self-QA run statement

  • I have clicked through the running application to see if all changes I made actually work.

Does this PR introduce a breaking change?

  • Yes
  • No

@velimd velimd requested a review from a team as a code owner October 11, 2024 09:40
@velimd velimd closed this Oct 11, 2024
@velimd velimd reopened this Oct 14, 2024
@mfallonhmcts mfallonhmcts merged commit 7107f0b into master Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishikrsharma rishikrsharma rishikrsharma approved these changes

Assignees
No one assigned
Labels
enable_keep_helm ns:money-claims prd:cmc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velimd @rishikrsharma @mfallonhmcts