Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Sync Develop with Master *Do NOT Merge* #575

Open
wants to merge 261 commits into
base: master
Choose a base branch
from

Conversation

hemantt
Copy link
Contributor

@hemantt hemantt commented Mar 27, 2020

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@hemantt hemantt changed the title Sync Develop with Master Sync Develop with Master *Do NOT Merge* Mar 27, 2020
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 27, 2020 13:36 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 27, 2020 13:37 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 27, 2020 13:38 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 27, 2020 13:39 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 30, 2020 10:52 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 30, 2020 11:12 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 31, 2020 08:20 Inactive
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #575 into release-cut-18.2 will increase coverage by 0.05%.
The diff coverage is 91.62%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release-cut-18.2     #575      +/-   ##
======================================================
+ Coverage               91.52%   91.58%   +0.05%     
- Complexity               2970     3048      +78     
======================================================
  Files                     388      395       +7     
  Lines                    7618     7791     +173     
  Branches                  522      535      +13     
======================================================
+ Hits                     6972     7135     +163     
- Misses                    517      523       +6     
- Partials                  129      133       +4     
Impacted Files Coverage Δ Complexity Δ
...tion/SpreadsheetValidationErrorMessageCreator.java 96.70% <0.00%> (-0.36%) 78.00 <0.00> (ø)
...d/definition/store/excel/parser/ParserFactory.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...n/store/excel/parser/model/DefinitionDataItem.java 96.34% <0.00%> (-1.19%) 41.00 <0.00> (ø)
...ository/AbstractDefinitionRepositoryDecorator.java 11.76% <ø> (ø) 2.00 <0.00> (ø)
...sitory/VersionedDefinitionRepositoryDecorator.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...tion/store/rest/endpoint/DisplayApiController.java 94.44% <50.00%> (+6.94%) 11.00 <1.00> (+2.00)
...xtype/EventComplexTypeEntityDefaultValueError.java 70.00% <70.00%> (ø) 1.00 <1.00> (?)
...re/excel/parser/SearchCasesResultLayoutParser.java 84.21% <84.21%> (ø) 9.00 <9.00> (?)
...nition/store/excel/parser/GenericLayoutParser.java 94.00% <87.50%> (-1.24%) 50.00 <4.00> (+5.00) ⬇️
...epository/entity/SearchCasesResultFieldEntity.java 87.50% <87.50%> (ø) 5.00 <5.00> (?)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc1d2d...bcd5055. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 31, 2020 08:58 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 31, 2020 15:58 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 1, 2020 06:30 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 1, 2020 07:00 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 1, 2020 09:31 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 2, 2020 13:12 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 3, 2020 09:12 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 6, 2020 10:46 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 7, 2020 08:46 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 7, 2020 16:08 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 07:42 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 10:07 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 10:29 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 11:34 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 11:45 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 12:08 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 12:18 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview April 8, 2020 14:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.