Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csfd 15 ungrey back button #1706

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

Conversation

joeevanshmcts
Copy link

@joeevanshmcts joeevanshmcts commented Mar 26, 2024

JIRA link (if applicable)

Change Description

I've included the epic above to show how there are other items of work associated to this. The purpose of this pull request is to ensure that the existing changes get pushed into master, while they're not 100% complete, they're an improvement on what is currently there in production as of the time of writing this. There are still some issues with the implementation, it's not perfect, but it is an improvement.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

joeevanshmcts and others added 25 commits February 12, 2024 15:09
We're in the process of debugging an issue where the user hits the review page & then hits change, the previous button is not always accessible.
CSFD-18 Event flow cancel navigation
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
52.0% Coverage on New Code (required ≥ 80%)
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants