Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gitlab sections #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rwese
Copy link

@rwese rwese commented Jul 1, 2024

  • added section support with or without approval count and optional flag
  • refactored cmd/main.go for cleaner ParseOptions passing (see)

If there are changes you need let me know.

René Weselowski and others added 2 commits July 1, 2024 11:01
this change adds support for sections, and their inheritance, which are
used in gitlab

- adds WithSectionSupport option, off by default
- support spaces in section names
- adds optional ^ character for sections

adds support for parsing section approval required, count

Fixes inconsistent function descriptions
before adding extra options via func parameters was getting overly long.
now we can pass ParseOptions...
@vincentjames501
Copy link

This would be amazing! We're looking to use this library to add some enforcements in gitlab ci and pre-commit hooks and just ran into the issue where it doesn't support sections. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants