basic integration test #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Merge 8.3.x-sync into master
🤖 Merge 8.3.x-sync into master
🤖 Merge 8.3.x-sync into master
🤖 Merge 8.3.x-sync into master
8 tasks
|
An attempt to produce a slicker integration test foundered upon cylc#6189 which prevents the onward triggering of flows in simulation mode. 😞 |
Comment on lines
+2046
to
+2047
| 'cylc set ${CYLC_WORKFLOW_ID} //1/good --flow=2\n' | ||
| 'cylc trigger ${CYLC_WORKFLOW_ID}//1/first --flow=2' |
There was a problem hiding this comment.
Running actual bash scripts including Cylc commands makes this a functional test, not an integration test.
There was a problem hiding this comment.
I think it should be possible to test this using start rather than run by calling:
schd.pool.set_prereqs_and_outputs(to set the output in flow 2)schd.pool.force_trigger_tasksorschd.pool.get_or_spawn_task(to spawn the upstream task in flow 2)schd.pool.spawn_on_outputs(to test the spawning of downstream tasks from upstream outputs)
There was a problem hiding this comment.
I'll give it a go. I was trying that approach when I ran into problems with sim mode, but actually, just not running in sim mode....
wxtim
force-pushed
the
hilary.flow-set-bug-fix.integration-test
branch
from
3277917 to
f5cf97d
Compare
hjoliver
force-pushed
the
flow-set-bug-fix
branch
6 times, most recently
from
c0ac01e to
8d6b02a
Compare
|
THis has been left behind and is now stale. Hilary has written a better test since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is barely an integration test: It runs the entire workflow which makes all the changes to itself.
I'm feeling my way towards a much more integration-style test, but it's not working yet.