Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylc set task 3 #45

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

oliver-sanders
Copy link

The "set" mutation in Tui had become broken by a scheduler interface change.

I hadn't tested it at the time due to an asyncio mismatch but found a quick and dirty way around it for now.

* Mutation had become broken by optional args becoming compulsory.
* Added a tui integration test to prevent accidental breakages.
* Ensure output "label != message" to avoid the potential for mixups.
Copy link
Owner

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@hjoliver hjoliver merged commit 7fd5d72 into hjoliver:cylc-set-task Mar 5, 2024
24 of 27 checks passed
@oliver-sanders oliver-sanders deleted the cylc-set-task-3 branch March 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants