cylc set stuffs #44
Merged
cylc set stuffs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that task/cycle selectors are not provided.
* It might feel natural to users to specify the task output as part of
* the task ID, but this won't work, so catch it early.
* Prohibit setting the (non-existent) "waiting" output
* Provide a more helpful error for Cylc 7 users who are likely to try
this.
* Also blacklist the "waiting" task state name from use in custom
outputs.
oliver-sanders
commented
Feb 27, 2024
Comment on lines
+328
to
+331
| if "waiting" in outputs: | ||
| raise InputError( | ||
| "Tasks can not be set to waiting, use a new flow to re-run" | ||
| ) |
There was a problem hiding this comment.
Pre-empting people trying to cylc set --out=waiting.
oliver-sanders
commented
Feb 27, 2024
Comment on lines
+379
to
+383
| if tokens['task_sel']: | ||
| raise InputError(SELECTOR_ERROR.format( | ||
| tokens['task'], | ||
| tokens['task_sel'], | ||
| )) |
There was a problem hiding this comment.
I absent-mindedly tried running a command like this cylc set workflow//cycle/task:output rather than cylc set workflow//cycle/task --out=output.
The CLI accepted this, but it didn't match any tasks because it merged the output in with the task name.
oliver-sanders
commented
Feb 27, 2024
Comment on lines
+44
to
+45
| poll_grep_workflow_log -E '19700101T0000Z/t1/01:submitted.* => running' | ||
| poll_grep_workflow_log -E '19700101T0000Z/t1/01:running.* => failed' |
There was a problem hiding this comment.
Test got missed as it isn't run in CI
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test which was broken by log format changes but isn't run in CI.
It also adds some extra validation to the
cylc setcommand to catch some likely user errors.