Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set: extra tests #40

Merged
merged 1 commit into from
Jan 20, 2024
Merged

set: extra tests #40

merged 1 commit into from
Jan 20, 2024

Conversation

oliver-sanders
Copy link

@oliver-sanders oliver-sanders commented Jan 19, 2024 •
edited
Loading

Working my way through the use cases, no issues so far.

  • Add links from the tests to the proposals.
  • Add test for use case 5 where a custom output is set without also setting a final output.
  • Add some integration tests to cover interaction with other features.

@oliver-sanders
set: add some tests
237e399 
* Add test for use case 5 where a custom output is set without also
  setting a final output.
* Add some integration tests to cover interaction with other features.
@oliver-sanders oliver-sanders changed the title Cylc set task set: extra tests Jan 19, 2024
@oliver-sanders oliver-sanders mentioned this pull request Jan 19, 2024
Merged
16 tasks
hjoliver
hjoliver approved these changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks

@hjoliver hjoliver merged commit 7545b53 into hjoliver:cylc-set-task Jan 20, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @hjoliver