Xtrig arg validate #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borked rebase? |
Rebase over a very, very old branch. |
broadcast: fix issues with filepaths and hash characters * Fix traceback when using `cylc broadcast -F` with a relative filepath * Fix `#` char bug in `cylc broadcast`
@hjoliver Might you rebase the base branch? |
hjoliver
force-pushed
the
xtrig-arg-validate
branch
from
9643892 to
d921641
Compare
|
Rebased |
hjoliver
force-pushed
the
xtrig-arg-validate
branch
from
f20559b to
d5bc789
Compare
add example workflows * Partially addresses cylc/cylc-doc#627 * Add some examples of Cylc workflow implementation patterns. --------- Co-authored-by: Hilary James Oliver <[email protected]> Co-authored-by: Ronnie Dutta <[email protected]>
wxtim
force-pushed
the
xtrig-arg-validate
branch
from
9e03ea6 to
326eaa1
Compare
* Closes cylc#5939 * Support offsets (measured from the ICP) for the `stop after cycle point` to mirror the behaviour of the `final cycle point`. * Add integration test to lock-down `stop after cycle point` interactions.
Merge 8.2.x-sync into master
doc: correct spelling
…examples for each of the built in xtriggers. - Xrandom validate function - Init test xrandom validate function - Add unit tests for validation of built in xtriggers
wxtim
force-pushed
the
xtrig-arg-validate
branch
from
a271282 to
6fea50f
Compare
Co-authored-by: Ronnie Dutta <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…f `tool.cylc.lint`
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
* Remove redundant try block. * Fix changelog * Automatically validate xtrigger function signature --------- Co-authored-by: Hilary James Oliver <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
Don't record satisfied xtriggers in the DB * Closes cylc#5911 * Test that no wall_clock xtriggers are saved to the DB for a retry. --------- Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Oliver Sanders <[email protected]>
…cov/codecov-action-4 build(deps): bump codecov/codecov-action from 3 to 4
added suite state xtrigger for back commpat extended back compat a unit test added deprecation log message Replace icky unit test with functional test (#4) --------- Co-authored-by: Mark Dawson <[email protected]>
🤖 Merge 8.2.x-sync into master
Co-authored-by: Mark Dawson <[email protected]>
cylc lint: deprecate `[cylc-lint]` in favour of `[tool.cylc.lint]` in `pyproject.toml`
stop after cycle point: support offsets
🤖 Merge 8.2.x-sync into master
* Improve xtrigger validation * wall_clock: use placeholder function for signature validation & autodocs * Fix docstring for autodoc [skip ci]
|
Stale, replaced by cylc#5955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close cylc#5448
This is not just a bug-fix for the
wall_clockxtrigger - I've gone for a generic approach:validate_configit will be called at validation time, with the parsed args.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.