reload: test reloading doesn't nudge the runahead limit #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Dec 20, 2023
| @@ -34,11 +34,11 @@ testpaths = | |||
| tests/integration/ | |||
| env = | |||
| # a weird timezone to check that tests aren't assuming the local timezone | |||
| TZ=XXX-09:35 | |||
| # TZ=XXX-09:35 | |||
There was a problem hiding this comment.
This has been removed on master, setting TZ within a Python session doesn't work right.
8 tasks
hjoliver
approved these changes
Dec 20, 2023
hjoliver
merged commit 8e55d6a
into
hjoliver:fix-runahead-compute
19 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this change also fixes cylc#5825, not sure I understand why, but it does, so here, have a test!