Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclical objects #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cyclical objects #28

wants to merge 2 commits into from

Conversation

benkrig
Copy link
Contributor

@benkrig benkrig commented Nov 30, 2019

Fixes #23

First go at fixing cyclical objects. Problem comes from a recursive / cyclical pattern coming in. The example posted over on #23 is good and reproducible.

Cyclical objects would now be represented like: owner: [Cyclic at: owner.data.owner = owner]

Check out this Stackoverflow for some overview.

@benkrig benkrig changed the title Fixes cyclical/cycling objects. Fixes cyclical objects. Nov 30, 2019
@benkrig benkrig changed the title Fixes cyclical objects. Fix cyclical objects. Nov 30, 2019
@benkrig benkrig changed the title Fix cyclical objects. Fix cyclical objects Nov 30, 2019
@n3wtron
Copy link

n3wtron commented Jun 16, 2020

Hi, this repo looks dead, what do u think about open a new fork like ngx-json-viewer2 (if I'm not wrong the MIT licence allow it) and merge thoose PR on that repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngx-json-viewer not rendering when complex/cyclic JSON is used.
2 participants