Add scss linter in web console (apache#7365)

* Add SCSS linter * Fixed SCSS styles
himanshug · Mar 29, 2019 · be1d7f8 · be1d7f8
1 parent ad7862c
commit be1d7f8
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 13 deletions.
diff --git a/web-console/.stylelintrc.json b/web-console/.stylelintrc.json
@@ -0,0 +1,17 @@
+{
+  "plugins": [
+    "stylelint-scss"
+  ],
+  "defaultSeverity": "error",
+  "extends": "stylelint-config-recommended-scss",
+  "rules": {
+    "indentation": 2,
+    "at-rule-no-unknown": null,
+    "scss/at-rule-no-unknown": true,
+    "scss/at-import-no-partial-leading-underscore": true,
+    "scss/dollar-variable-colon-space-after": "always",
+    "scss/dollar-variable-colon-space-before": "never",
+    "no-descending-specificity": null,
+    "no-missing-end-of-source-newline": true
+  }
+}
diff --git a/web-console/package.json b/web-console/package.json
@@ -16,7 +16,8 @@
     "test": "jest --silent 2>&1",
     "generate-licenses-file": "license-checker --production --json --out licenses.json",
     "check-licenses": "license-checker --production --onlyAllow 'Apache-1.1;Apache-2.0;BSD-2-Clause;BSD-3-Clause;MIT;CC0-1.0' --summary",
-    "start": "webpack-dev-server --hot --open"
+    "start": "webpack-dev-server --hot --open",
+    "stylelint": "stylelint 'src/**/*.scss'"
   },
   "dependencies": {
     "@blueprintjs/core": "1.0.1",
@@ -66,6 +67,9 @@
     "postcss-preset-env": "^6.5.0",
     "sass-loader": "^7.1.0",
     "style-loader": "^0.23.1",
+    "stylelint": "^9.10.1",
+    "stylelint-config-recommended-scss": "^3.2.0",
+    "stylelint-scss": "^3.5.4",
     "stylus": "^0.54.5",
     "ts-jest": "^23.10.5",
     "ts-loader": "^5.3.3",

diff --git a/web-console/src/components/auto-form.scss b/web-console/src/components/auto-form.scss
@@ -20,4 +20,4 @@
   .ace_scroller {
     background-color: #212c36;
   }
-}
+}
diff --git a/web-console/src/components/rule-editor.scss b/web-console/src/components/rule-editor.scss
@@ -16,20 +16,18 @@
  * limitations under the License.
  */
 
- .rule-editor {
-   .right {
+.rule-editor {
+  .right {
     text-align: right;
-   }
+  }
 
   margin-bottom: 20px;
 
-   .title {
-
-
+  .title {
     display: flex;
 
     .spacer {
       flex: 1;
     }
-   }
- }
+  }
+}
diff --git a/web-console/src/components/sql-control.scss b/web-console/src/components/sql-control.scss
@@ -58,4 +58,4 @@
   .function-doc-name {
     font-size: 18px;
   }
-}
+}
diff --git a/web-console/src/dialogs/lookup-edit-dialog.scss b/web-console/src/dialogs/lookup-edit-dialog.scss
@@ -42,4 +42,4 @@
   .ace_gutter-layer {
     background-color: #27313c;
   }
-}
+}
diff --git a/web-console/src/views/lookups-view.scss b/web-console/src/views/lookups-view.scss
@@ -31,4 +31,4 @@
     text-align: center;
     margin-top: 35vh;
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,4 +20,4 @@ @@
       .ace_scroller {
         background-color: #212c36;
       }
-    }
+    }