-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread arguments to GuildChannel.edit + applied tags to edit_cannel #1474
Add thread arguments to GuildChannel.edit + applied tags to edit_cannel #1474
Conversation
Just to reiterate. I have run Nox. MyPy fails because the signature of |
#1053 Also this issue is very likely related. I'd be willing to do what's necessary to close it, just need guidance on the next step. |
Wouldn't you add these new arguments to the signature for |
I've merged what I had in I've also updated the test for |
Co-authored-by: GoogleGenius <[email protected]> Signed-off-by: Zechariah Zimmerman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for working on this and spotting the missing arguments!
Co-authored-by: davfsa <[email protected]> Signed-off-by: Zechariah Zimmerman <[email protected]>
Summary
Implements
GuildThreadChannel.edit
to add support for thread-specific edit fields. Also adds support for applied tags inRESTClient.edit_channel
.MyPy fails because the signature of
GuildThreadChannel.edit
no longer matches the signature ofGuildChannel.edit
. Uncertain how to proceed with that.Checklist
nox
and all the pipelines have passed.Related issues
#1053