Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add plugins to higress console #315

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Conversation

cr7258
Copy link
Member

@cr7258 cr7258 commented Jun 22, 2024

Screenshot

image image

Plugin's phase and priority

# AUTHN
## Authentication 
basic-auth
  phase: AUTHN
  priority: 10
key-auth
  phase: AUTHN
  priority: 20
oidc
  phase: AUTHN
  priority: 30
jwt-auth
  phase: AUTHN
  priority: 40
hmac-auth
  phase: AUTHN
  priority: 50
simple-jwt-auth
  phase: AUTHN
  priority: 60

## Request Restriction
ip-restriction
  phase: AUTHN
  priority: 200
request-block
  phase: AUTHN
  priority: 210
request-validation
  phase: AUTHN
  priority: 220

## Request/Response Transformation
custom-response
  phase: AUTHN
  priority: 400
transformer
  phase: AUTHN
  priority: 410
cache-control
  phase: AUTHN
  priority: 420
de-graphql
  phase: AUTHN
  priority: 430


# AUTHZ
## Security
bot-detect
  phase: AUTHZ
  priority: 10
waf
  phase: AUTHZ
  priority: 20
cors
  phase: AUTHZ
  priority: 30


# UNSPECIFIED_PHASE
## Traffic Management
key-rate-limit
  phase: UNSPECIFIED_PHASE
  priority: 10
cluster-key-rate-limit
  phase: UNSPECIFIED_PHASE
  priority: 20

## Application
ai-cache
  phase: UNSPECIFIED_PHASE
  priority: 200
ai-token-ratelimit
  phase: UNSPECIFIED_PHASE
  priority: 210
ai-security-guard
  phase: UNSPECIFIED_PHASE
  priority: 220
ai-prompt-template
  phase: UNSPECIFIED_PHASE
  priority: 230
ai-prompt-decorator
  phase: UNSPECIFIED_PHASE
  priority: 240
ai-proxy
  phase: UNSPECIFIED_PHASE
  priority: 250
ai-rag
  phase: UNSPECIFIED_PHASE
  priority: 260
ai-statistics
  phase: UNSPECIFIED_PHASE
  priority: 270
ai-transformer
  phase: UNSPECIFIED_PHASE
  priority: 280

Related PR

Update the higress documentation to ensure that the plugin name is consistent with higress console.
higress-group/higress-group.github.io#242

fixes #132, #131, #130, #129, #128

@@ -14,7 +16,7 @@ info:
email: [email protected]
spec:
phase: AUTHN
priority: 320
priority: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已有的priority不要做调整,我们企业版也是统一的priority

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 那已有的 priority 有没有什么规律可以遵循?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnlanni 我把现有的 priority 恢复了,并且基于现有的规律调整了新增插件的 priority。

# AUTHN

ai-cache
  phase: AUTHN
  priority: 10

## Request Restriction
ip-restriction
  phase: AUTHN
  priority: 210

request-validation
  phase: AUTHN
  priority: 220

## Authentication 
key-auth
  phase: AUTHN
  priority: 310
basic-auth
  phase: AUTHN
  priority: 320
hmac-auth
  phase: AUTHN
  priority: 330
jwt-auth
  phase: AUTHN
  priority: 340
oidc
  phase: AUTHN
  priority: 350

## Request/Response Transformation
transformer
  phase: AUTHN
  priority: 410
cache-control
  phase: AUTHN
  priority: 420
de-graphql
  phase: AUTHN
  priority: 430
custom-response
  phase: AUTHN
  priority: 910


# AUTHZ
## Security
bot-detect
  phase: AUTHZ
  priority: 310
request-block
  phase: AUTHZ
  priority: 320
waf
  phase: AUTHZ
  priority: 330
cors
  phase: AUTHZ
  priority: 340

# UNSPECIFIED_PHASE
## Traffic Management
key-rate-limit
  phase: UNSPECIFIED_PHASE
  priority: 10
cluster-key-rate-limit
  phase: UNSPECIFIED_PHASE
  priority: 20

## Application
ai-proxy
  phase: UNSPECIFIED_PHASE
  priority: 100
ai-statistics
  phase: UNSPECIFIED_PHASE
  priority: 200
ai-security-guard
  phase: UNSPECIFIED_PHASE
  priority: 300
ai-rag
  phase: UNSPECIFIED_PHASE
  priority: 400
ai-prompt-decorator
  phase: UNSPECIFIED_PHASE
  priority: 450
ai-prompt-template
  phase: UNSPECIFIED_PHASE
  priority: 500
ai-transformer
  phase: UNSPECIFIED_PHASE
  priority: 550
ai-token-ratelimit
  phase: UNSPECIFIED_PHASE
  priority: 600

@cr7258 cr7258 requested a review from johnlanni June 27, 2024 03:12
@johnlanni johnlanni merged commit 1316d36 into higress-group:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为 key-rate-limit 插件编写 spec.yaml
2 participants